Skip to content

Added get started button to home page#548

Open
dafuga wants to merge 7 commits into
devfrom
adding-getting-started-button
Open

Added get started button to home page#548
dafuga wants to merge 7 commits into
devfrom
adding-getting-started-button

Conversation

@dafuga
Copy link
Copy Markdown
Member

@dafuga dafuga commented Nov 24, 2025

No description provided.

@dafuga dafuga changed the title chore: added get started button to home page Added get started button to home page Nov 24, 2025
dafuga
dafuga commented Nov 24, 2025
View reviewed changes
Comment thread src/routes/[[locale]]/[network]/(homepage)/components/get-started.svelte Outdated
return hasWebAuth;
}

$effect(() => {
Copy link
Copy Markdown
Member Author

@dafuga dafuga Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it takes a second for it to become available, but I got it working without the polling.

Copy link
Copy Markdown
Member

@aaroncox aaroncox Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onMount ?

Why wouldn't it be available?

Copy link
Copy Markdown
Member Author

@dafuga dafuga Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but it doesn’t seem to be available right away on page load.

Copy link
Copy Markdown
Member Author

@dafuga dafuga Nov 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that it takes a second for it to become available, but I got it working without the polling.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented Nov 24, 2025 •
edited
Loading

Deploying unicove-jungle4 with  Cloudflare Pages  Cloudflare Pages

Latest commit: b2f31b1
Status: ✅  Deploy successful!
Preview URL: https://4ba1291c.unicove-jungle4.pages.dev
Branch Preview URL: https://adding-getting-started-butto.unicove-jungle4.pages.dev

View logs

@dafuga dafuga force-pushed the adding-getting-started-button branch from e15eb8a to 5a7cdb8 Compare November 24, 2025 03:36
dafuga
dafuga commented Nov 24, 2025
View reviewed changes
Comment thread src/routes/[[locale]]/[network]/(homepage)/components/hero.svelte
<div class="grid gap-4">
<!-- <div class="grid gap-4 @2xl:grid-cols-2"> -->
<!-- <Button variant="primary">Create your Vaulta account</Button> -->
<Button
Copy link
Copy Markdown
Member Author

@dafuga dafuga Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that it's fine to remove this button at this point.

Copy link
Copy Markdown
Member

@aaroncox aaroncox Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so

@dafuga dafuga force-pushed the adding-getting-started-button branch from 5a7cdb8 to 334fc76 Compare November 24, 2025 03:43
@dafuga dafuga force-pushed the adding-getting-started-button branch from 334fc76 to dec0f8b Compare November 24, 2025 03:44
@dafuga dafuga force-pushed the adding-getting-started-button branch from 03e2eb8 to f204691 Compare November 25, 2025 04:27
@dafuga dafuga force-pushed the adding-getting-started-button branch from 86972e8 to b31e3c3 Compare November 25, 2025 04:34
deansallinen
deansallinen reviewed Nov 25, 2025
View reviewed changes
Comment thread src/routes/[[locale]]/[network]/(homepage)/components/hero.svelte Outdated
>
<span class="">Unicove -</span>
The {networkName} web wallet and block explorer.
Unicove Your Gateway To The Vaulta Network.
Copy link
Copy Markdown
Contributor

@deansallinen deansallinen Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking there should be some punctuation after "Unicove"

Either: "Unicove: Your gateway to the Vaulta network"

Or: "Unicove. Your gateway to the Vaulta network"

Copy link
Copy Markdown
Contributor

@deansallinen deansallinen Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, would hardcoding "Vaulta" be a problem for Telos/Wax/etc.?

Copy link
Copy Markdown
Contributor

@deansallinen deansallinen Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, we could remove "Unicove" from this line altogether and have it as a wordmark under/over the vaulta logo in the left column.

Copy link
Copy Markdown
Member Author

@dafuga dafuga Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the vaulta() snippet so it won't affect what is displayed for Telos or WAX.

Copy link
Copy Markdown
Member Author

@dafuga dafuga Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And sounds good, I'll just remove the word Univove for now 👍

deansallinen
deansallinen reviewed Nov 25, 2025
View reviewed changes
Comment thread src/routes/[[locale]]/[network]/(homepage)/components/get-started.svelte Outdated

{#if pluginAvailable}
<Button variant="primary" class="w-fit" onclick={handleGetStarted}
>Get Started - Create Account</Button
Copy link
Copy Markdown
Contributor

@deansallinen deansallinen Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This button label has two actions: "Get started" and "Create account". Maybe we choose one or the other?

Or combine them? "Get started with an account"

@deansallinen Axolo.co
Copy link
Copy Markdown
Contributor

deansallinen commented Nov 25, 2025

Otherwise, it looks good to me

Slack File: image.png

@deansallinen Axolo.co
Copy link
Copy Markdown
Contributor

deansallinen commented Nov 25, 2025

Except for mobile: the vertical spacing is now broken

Slack File: localhost_5174_en_vaulta(iPhone SE).png

@deansallinen Axolo.co
Copy link
Copy Markdown
Contributor

deansallinen commented Nov 25, 2025 •
edited
Loading

If the text is centered on mobile breakpoints, the button should also be centered.

@dafuga Axolo.co
Copy link
Copy Markdown
Member Author

dafuga commented Nov 25, 2025

Good catch 👍

@dafuga Axolo.co
Copy link
Copy Markdown
Member Author

dafuga commented Nov 25, 2025

I always forget to check what things look like on mobile 😂

@dafuga Axolo.co
Copy link
Copy Markdown
Member Author

dafuga commented Nov 26, 2025 •
edited
Loading

@deansallinen Fixed 👍

Slack File: Screenshot 2025-11-25 at 9.26.46 PM.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaroncox aaroncox aaroncox left review comments

@deansallinen deansallinen deansallinen left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dafuga @deansallinen @aaroncox