feat: remove wrapping over rest calls with StudyException #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMaskedTurtle
force-pushed
the
jorism/feat/reduce-complexity-of-error-handling
branch
from
85b6491 to
42f1b07
Compare
dbraquart
force-pushed
the
jorism/feat/implemet-new-error-handler
branch
from
fbdf43f to
47c9f4e
Compare
dbraquart
force-pushed
the
jorism/feat/reduce-complexity-of-error-handling
branch
from
bb740b9 to
3982894
Compare
TheMaskedTurtle
force-pushed
the
jorism/feat/reduce-complexity-of-error-handling
branch
4 times, most recently
from
d04b762 to
766cae5
Compare
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/feat/reduce-complexity-of-error-handling
branch
from
88006b9 to
553b2c8
Compare
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/feat/reduce-complexity-of-error-handling
branch
from
50f6a30 to
340e474
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
To apply the new dogma for error handling we have to remove simple wrappers around rest calls. We should keep anything with added value but we want to delete all the try/catch that just wraps the initial error in a StudyException.