-
Notifications
You must be signed in to change notification settings - Fork 2
enhancement for feeder bays infos endpoint #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement for feeder bays infos endpoint #874
Conversation
EtienneLt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor things
|
|
||
| @GetMapping(value = "/studies/{studyUuid}/root-networks/{rootNetworkUuid}/nodes/{nodeUuid}/network/voltage-levels/{voltageLevelId}/feeder-bays-and-bus-bar-sections") | ||
| @GetMapping(value = "/studies/{studyUuid}/root-networks/{rootNetworkUuid}/nodes/{nodeUuid}/network/voltage-levels/{voltageLevelId}/feeder-bays") | ||
| @Operation(summary = "get feeder bays and bus bar sections information for a given network and voltage level") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change summary
| @GetMapping(value = "/studies/{studyUuid}/root-networks/{rootNetworkUuid}/nodes/{nodeUuid}/network/voltage-levels/{voltageLevelId}/feeder-bays-and-bus-bar-sections") | ||
| @GetMapping(value = "/studies/{studyUuid}/root-networks/{rootNetworkUuid}/nodes/{nodeUuid}/network/voltage-levels/{voltageLevelId}/feeder-bays") | ||
| @Operation(summary = "get feeder bays and bus bar sections information for a given network and voltage level") | ||
| @ApiResponse(responseCode = "200", description = "Feeder bays and bus bar sections information of the given voltage level retrieved") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change response
| } | ||
|
|
||
| public String getVoltageLevelInformation(UUID nodeUuid, UUID rootNetworkUuid, String voltageLevelId, | ||
| public String getFeederBaysInfos(UUID nodeUuid, UUID rootNetworkUuid, String voltageLevelId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well for endpoint /switches I think "getVoltageLevelInformation" was more appropriate what do you think ?
| } | ||
|
|
||
| public String getVoltageLevelInformation(UUID nodeUuid, UUID rootNetworkUuid, String voltageLevelId, boolean inUpstreamBuiltParentNode, String path) { | ||
| public String getFeederBaysInfos(UUID nodeUuid, UUID rootNetworkUuid, String voltageLevelId, boolean inUpstreamBuiltParentNode, String path) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, I think it is better with previous name
…ar-section-to-feeder-bays' into change-feeder-bays-and-bus-bus-bar-section-to-feeder-bays
|
EtienneLt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK code OK



PR Summary
change feeder bays and bus bar section to feeder bays endpoint