Open
Conversation
Trashbin retention 35 days
aptiko
requested changes
Apr 24, 2024
Collaborator
aptiko
left a comment
There was a problem hiding this comment.
Since team-collaboration-toolkit is not specifically for us, but for general use, it doesn't seem right to hardwire our own special requirements. Since this parameter already has a default in nextcloud, "auto", we shouldn't specify another default here. What we should do instead is add a nextcloud_trashbin_retention_obligation parameter to the nextcloud role, which by default will have the same value as the upstream default, i.e. "auto", and use that parameter in our own Ansible playbook.
(Incidentally, I think I haven't named the parameters of the nextcloud role well, they should all have a nextcloud_ prefix.)
BTW, again, I think a better commit message is needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trashbin retention 35 days