Skip to content

Update install.yml#6

Open
gpapadoka wants to merge 1 commit intomasterfrom
gpapadoka-patch-2
Open

Update install.yml#6
gpapadoka wants to merge 1 commit intomasterfrom
gpapadoka-patch-2

Conversation

@gpapadoka
Copy link
Copy Markdown
Collaborator

Trashbin retention 35 days

Trashbin retention 35 days
Copy link
Copy Markdown
Collaborator

@aptiko aptiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since team-collaboration-toolkit is not specifically for us, but for general use, it doesn't seem right to hardwire our own special requirements. Since this parameter already has a default in nextcloud, "auto", we shouldn't specify another default here. What we should do instead is add a nextcloud_trashbin_retention_obligation parameter to the nextcloud role, which by default will have the same value as the upstream default, i.e. "auto", and use that parameter in our own Ansible playbook.

(Incidentally, I think I haven't named the parameters of the nextcloud role well, they should all have a nextcloud_ prefix.)

BTW, again, I think a better commit message is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants