Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ tmp
*.swp
*.un~
.tags
.DS_Store
2 changes: 1 addition & 1 deletion greenhouse_io.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "bundler", "~> 1.3"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec", "~> 3.4.0"
spec.add_development_dependency "webmock", "~> 1.22.6"
spec.add_development_dependency "webmock", "~> 2.0.0"
spec.add_development_dependency "vcr", "~> 3.0.1"
end
6 changes: 5 additions & 1 deletion lib/greenhouse_io/api/job_board.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def job(id, options = {})
end

def apply_to_job(job_form_hash)
post_to_job_board_api('/applications', { :body => job_form_hash, :basic_auth => basic_auth })
post_to_job_board_api('/applications', { body: job_form_hash, headers: post_headers })
end

private
Expand All @@ -54,6 +54,10 @@ def get_from_job_board_api(url, options = {})
end
end

def post_headers
{ 'Authorization' => 'Basic ' + Base64.encode64(api_token), 'Content-Type' => 'application/json' }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be the base64 of api_token + ':' ? (to be a username with no password)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't disagree with you - I will test when I get a chance.
Just working from the API docs https://github.com/grnhse/greenhouse-api-docs/blob/master/source/includes/job-board/_applications.md#request-headers
and it seems to work fine without.

end

def post_to_job_board_api(url, options)
response = post_response(url, options)
if response.code == 200
Expand Down
8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/apply_to_job.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/activity_feed.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions spec/fixtures/cassettes/client/all_scorecards.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/application.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions spec/fixtures/cassettes/client/application_by_job_id.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/applications.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/candidate.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/candidates.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions spec/fixtures/cassettes/client/create_candidate_note.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/department.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/departments.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions spec/fixtures/cassettes/client/headers.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading