-
Notifications
You must be signed in to change notification settings - Fork 4.6k
mem: Allow overriding the default buffer pool. #8806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The default buffer pool only has a only a few tiers, which hurts performance in some applications. In, it was decided that instead of adding more tiers to the default pool, we should allow changing the default pool.
|
I didn't know if you |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8806 +/- ##
==========================================
- Coverage 83.30% 83.29% -0.01%
==========================================
Files 418 417 -1
Lines 33004 32980 -24
==========================================
- Hits 27493 27470 -23
+ Misses 4102 4099 -3
- Partials 1409 1411 +2
🚀 New features to boost your workflow:
|
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
I can't figure out how to get the PR validation to pass. My initial PR title didn't start with "mem:", but now it does. |
|
@vanja-p can you check if the test failing is related to the changes or not? |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
@eshitachandwani, looks like it's not related to my change. Rerunning them passed, and also, my 2 new lines don't have any coverage. |
The default buffer pool only has a only a few tiers, which hurts performance in some applications. In #8770, it was decided that instead of adding more tiers to the default pool, we should allow changing the default pool.
RELEASE NOTES: