Skip to content

Conversation

@mbissa
Copy link
Contributor

@mbissa mbissa commented Jan 7, 2026

This PR leverages the async gauge framework and implements the xdsclient metrics to report number of xds resources and whether or not the xDS client currently has a working ADS stream to the xDS server along with the required labels as part of A78

RELEASE NOTES:

  • xds/internal/client: Add async gauge metrics for "grpc.xds_client.connected" and "grpc.xds_client.resources" as part of A78.

@mbissa mbissa added this to the 1.79 Release milestone Jan 7, 2026
@mbissa mbissa requested a review from easwars January 7, 2026 01:18
@mbissa mbissa self-assigned this Jan 7, 2026
@mbissa mbissa added Type: Feature New features or improvements in behavior Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 74.22680% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.23%. Comparing base (c6d5e5e) to head (ec83a4e).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
internal/xds/xdsclient/clientimpl.go 25.92% 19 Missing and 1 partial ⚠️
internal/xds/clients/xdsclient/xdsclient.go 92.42% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8807      +/-   ##
==========================================
- Coverage   83.26%   83.23%   -0.03%     
==========================================
  Files         418      418              
  Lines       33004    33101      +97     
==========================================
+ Hits        27480    27551      +71     
- Misses       4109     4135      +26     
  Partials     1415     1415              
Files with missing lines Coverage Δ
internal/xds/clients/xdsclient/ads_stream.go 85.06% <100.00%> (+0.21%) ⬆️
internal/xds/clients/xdsclient/xdsclient.go 86.61% <92.42%> (+2.03%) ⬆️
internal/xds/xdsclient/clientimpl.go 73.72% <25.92%> (-11.74%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants