Skip to content

Spelling#2250

Open
jsoref wants to merge 21 commits into
grpc:mainfrom
jsoref:spelling
Open

Spelling#2250
jsoref wants to merge 21 commits into
grpc:mainfrom
jsoref:spelling

Conversation

@jsoref

@jsoref jsoref commented Jun 18, 2025

Copy link
Copy Markdown

jsoref added 5 commits June 17, 2025 21:49
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

@glbrntt glbrntt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this, a few of these changes are incorrect though.

Comment thread Sources/GRPCCodeGen/Internal/Renderer/TextBasedRenderer.swift Outdated
Comment thread Sources/GRPCCore/Streaming/Internal/BroadcastAsyncSequence.swift Outdated
Comment thread Tests/GRPCCoreTests/Call/Server/Internal/ServerRPCExecutorTests.swift Outdated
Comment thread Tests/GRPCCoreTests/Configuration/Generated/code.pb.swift Outdated
Comment thread Tests/GRPCCoreTests/Configuration/Generated/service_config.pb.swift
Comment thread dev/protos/upstream/google/rpc/code.proto Outdated
jsoref added 6 commits June 18, 2025 09:12
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
jsoref added 10 commits June 18, 2025 09:20
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@glbrntt

glbrntt commented Jun 18, 2025

Copy link
Copy Markdown
Collaborator

Sorry, would you mind opening this against https://github.com/grpc/grpc-swift-2 instead?

@jsoref

jsoref commented Jun 18, 2025

Copy link
Copy Markdown
Author

Sure. It won't be instant. I'm a human and have a day-job.

Maybe the main branch should be deleted from this repository?

I know there's text in the readme:

grpc-swift/README.md

Lines 6 to 15 in 664cc40

> [!IMPORTANT]
>
> See [grpc/grpc-swift-2](https://github.com/grpc/grpc-swift-2) for **gRPC Swift 2**
> which is the current major version of gRPC Swift.
## Versions
This repository contains the code for **gRPC Swift 1** which is now in maintenance
mode. Only bug fixes and security fixes will be applied. The support window for
1.x will also decrease over time as new Swift versions are released.

But it didn't really help me. I actually first drafted a PR against 1.x and then decided to write one against main ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants