version with initializer list#2
Open
Ippyb wants to merge 6 commits intoadded_valve_class_restructuringfrom
Open
version with initializer list#2Ippyb wants to merge 6 commits intoadded_valve_class_restructuringfrom
Ippyb wants to merge 6 commits intoadded_valve_class_restructuringfrom
Conversation
proan
reviewed
Oct 22, 2021
| _servopin(0), | ||
| _counter(0), | ||
| _servo(s1), | ||
| _buttonstate(LOW), |
Ayeeti
approved these changes
Nov 5, 2021
Collaborator
Ayeeti
left a comment
Ayeeti
left a comment
There was a problem hiding this comment.
Code has been tested and works.
proan
approved these changes
Nov 8, 2021
| _buttonpin(0), | ||
| _servopin(0), | ||
| _counter(0), | ||
| _servo(s1), |
There was a problem hiding this comment.
I don't like how we have to pass in an object here, but this has more to do with our object structure than with the initializer list. Before we change this, we need to consider how those structural changes will affect the rest of our code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.