TinyIoC: Fix missing XML documentation #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A better fix is to not include the raw CS file, but rather a built DLL in the nuget package. see issue #54 |
|
@ghostsquad the whole point of tinyioc is to not do that.. so no, that's not a "better fix" |
|
I agree with @grumpydev, in my case TinyIoC must be included as a cs-file, and made internal. Exactly the point why TinyIoC is distributed as it is. |
|
Any plans on getting this merged? :) As a workaround I'm adding some pragma statements to the file in the project I'm currently working on. |
|
Can you fix the merge conflicts and we'll accept this pr with the documentation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently did some work in a project where the assembly including TinyIoC built XML documentation, and they had enabled 'Treat warning as errors', so TinyIoC caused compile errors out of the box.
This PR fixes this.