This repository was archived by the owner on Jun 15, 2023. It is now read-only.
#84 Support for language id and full file name extensions #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the language server implementation extension and language id are different. So then the specific language id must be provided. Now the RawCommandServerDefinition.scala support excepting language id as well. Some of the language server implementation are based on cetain file names than the extension. Now as a fallback option if the extension (which is more prominent approach) is not found the LSP will look for file name mapping as well. Signed-off-by: gayanper <[email protected]>
gtache
reviewed
Jul 2, 2019
| connected = true | ||
| } | ||
| }) | ||
|
|
There was a problem hiding this comment.
There is probably a if (!connected) missing here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the language server implementation extension and language id are
different. So then the specific language id must be provided. Now the
RawCommandServerDefinition.scala support excepting language id as well.
Some of the language server implementation are based on cetain file
names than the extension. Now as a fallback option if the extension
(which is more prominent approach) is not found the LSP will look for
file name mapping as well.
Signed-off-by: gayanper [email protected]