Skip to content

feat(oci): support for insecure registries#2844

Open
brandtkeller wants to merge 3 commits intoguacsec:mainfrom
brandtkeller:2828_insecure_oci
Open

feat(oci): support for insecure registries#2844
brandtkeller wants to merge 3 commits intoguacsec:mainfrom
brandtkeller:2828_insecure_oci

Conversation

@brandtkeller
Copy link

Description of the PR

This PR implements support for configurable TLS verification settings on the OCI collectors. This is allows for prototyping and deployments with othewise insecure registries.

The updates use an options struct for future extension. I'll create an additional issue to support self-signed client cacert/client-cert/client-key and this pattern will allow extensions naturally.

Fixes #2828

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Signed-off-by: Brandt Keller <brandt.keller@defenseunicorns.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Support for TLS configuration on OCI Collector

3 participants