[Fix] Pass temperature=0.0 to OpenAI/AzureAI instead of dropping it - #1504
Open
RezaRahemtola wants to merge 1 commit into
Open
[Fix] Pass temperature=0.0 to OpenAI/AzureAI instead of dropping it#1504RezaRahemtola wants to merge 1 commit into
RezaRahemtola wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gen(temperature=0.0)on OpenAI/AzureAI silently falls back to the endpoint's default temperature (1.0) instead of passing0.0.The kwarg is gated on
if node.temperature:, which is falsy for0.0in Python. It looks like the same fix was applied tosubgrammar()in #1459 but missed the model adapters.This PR swaps the truthiness guard for
is not None, matching the rest of the codebase. Also fixed the same pattern in the experimental sglang and litellm adapters, and added a regression test.