Skip to content

fix: mitigate the UI jumping issue when resizing the window on iPad #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: mitigate the UI jumping issue when resizing the window on iPad #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Sources/Mantis/CropView/CropView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ final class CropView: UIView {
var forceFixedRatio = false
var checkForForceFixedRatioFlag = false
let cropViewConfig: CropViewConfig
private var debounceWorkItem: DispatchWorkItem?

private var flipOddTimes = false

Expand Down Expand Up @@ -879,9 +880,16 @@ extension CropView: CropViewProtocol {

let contentRect = getContentBounds()

adjustUIForNewCrop(contentRect: contentRect) { [weak self] in
self?.viewModel.setBetweenOperationStatus()
debounceWorkItem?.cancel()

let workItem = DispatchWorkItem { [weak self] in
self?.adjustUIForNewCrop(contentRect: contentRect) { [weak self] in
self?.viewModel.setBetweenOperationStatus()
}
}

debounceWorkItem = workItem
DispatchQueue.main.asyncAfter(deadline: .now() + 0.2, execute: workItem)
Comment on lines +883 to +892
Copy link

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The debounce delay of 0.2 seconds is a magic number. Consider extracting it to a named constant (e.g., private let debounceDelay: TimeInterval = 0.2) at the class level to improve maintainability and make it easier to adjust if needed.

Copilot uses AI. Check for mistakes.
}
}

Expand Down