fix(legend): prevent panic when only legends are set without series colors #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
When users set only
SeriesLegendswithoutSeriesColors, the legend functionality would panic. This occurred because the code attempted to access theconfig.SeriesColorsarray, and if the array was empty or the index was out of bounds, it would cause an array index out of bounds error.In the case, use default color when series colors are not provided to avoid out-of-range error.
Issues
resolves #60
Impact
Testing
I've tested locally, added test case to verify:
However, I didn't found the place that place the test files, I just remained it in locally : )
I already asked about solving this in #60 comments~