Added support for Spirit Race #258
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the stance for chinese log ids? Spirit Race for them is 48133 and was added to EI https://github.com/baaron4/GW2-Elite-Insights-Parser/pull/1063/files 
|
|
I am definitely up for supporting those too when possible without adding too much maintenance pain, this should be absolutely fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same success detection as Elite Insights.
The reward detection works correctly for repeated clears in the same week as can be seen in this screenshot, I have successes on the 19th, 20th and 21st of January
You can set the manager version once merged