update Makefile for test - #74
wenhuizhang wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Tests are failing because this isn't compiled anywhere.
|
@wenhuizhang why do we need this? #73 is taking care of client testing. The executable you're running aren't even compiled anywhere. Closing for now. |
|
Oh, in my humble opinion, #73 is taking care of tests for client, yet not On Wed, Apr 29, 2015 at 5:51 PM, Phil Lopreiato notifications@github.com
V/R, Wenhui Zhang Email: wenhui@gwmail.gwu.edu |
|
I think the tests for the server code are in a pretty good state right now, so I don't think any more are necessary. Plus, there isn't even any C code referenced by your makefile - read the test output to see where. Unless @Atryus disagrees, I think this one should stay closed. |
|
I agree with @phil-lopreiato about keeping this closed. Phil and I will talk tomorrow and figure out what needs to be refactored. We will create an issue tomorrow instructing exactly what needs to be done. |
|
Just updated and changed dir for include headers in server-kv-test and client-kv-test, and it works for me now, created a new push, pls let me know if you have any questions @zhangwei1984 @phil-lopreiato @Atryus |
No description provided.