Skip to content

update Makefile for test - #74

Closed
wenhuizhang wants to merge 1 commit into
gwAdvNet2015:masterfrom
wenhuizhang:server-update
Closed

wenhuizhang wants to merge 1 commit into
gwAdvNet2015:masterfrom
wenhuizhang:server-update

Conversation

@wenhuizhang

Copy link
Copy Markdown
Member

No description provided.

Comment thread server/test/Makefile

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are failing because this isn't compiled anywhere.

@phil-lopreiato

Copy link
Copy Markdown
Member

@wenhuizhang why do we need this? #73 is taking care of client testing. The executable you're running aren't even compiled anywhere. Closing for now.

@wenhuizhang

Copy link
Copy Markdown
Member Author

Oh, in my humble opinion, #73 is taking care of tests for client, yet not
for server, if I did not make it wrong, please correct me if I did.

On Wed, Apr 29, 2015 at 5:51 PM, Phil Lopreiato notifications@github.com
wrote:

@wenhuizhang https://github.com/wenhuizhang why do we need this? #73
#73 is taking care of
client testing. The executable you're running aren't even compiled
anywhere. Closing for now.


Reply to this email directly or view it on GitHub
#74 (comment)
.

V/R,

Wenhui Zhang

Email: wenhui@gwmail.gwu.edu
Telephone: 1-(703) 424 3193

@phil-lopreiato

Copy link
Copy Markdown
Member

I think the tests for the server code are in a pretty good state right now, so I don't think any more are necessary.

Plus, there isn't even any C code referenced by your makefile - read the test output to see where.

Unless @Atryus disagrees, I think this one should stay closed.

@amygara

amygara commented Apr 30, 2015

Copy link
Copy Markdown
Contributor

I agree with @phil-lopreiato about keeping this closed. Phil and I will talk tomorrow and figure out what needs to be refactored. We will create an issue tomorrow instructing exactly what needs to be done.

@wenhuizhang

Copy link
Copy Markdown
Member Author

Just updated and changed dir for include headers in server-kv-test and client-kv-test, and it works for me now, created a new push, pls let me know if you have any questions @zhangwei1984 @phil-lopreiato @Atryus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants