Merged
Conversation
Add resource reservation of memory for nodes
gyptazy
force-pushed
the
feature/373-add-resource-reservation-for-nodes
branch
from
8aff2e8 to
8499b3e
Compare
gyptazy
force-pushed
the
feature/373-add-resource-reservation-for-nodes
branch
2 times, most recently
from
c742458 to
636763f
Compare
Owner
Author
|
Hey @Chipmonk2, I made some additional changes to this PR. It is now directly integrated into the maxmem evaluation of the node and simply returns the adjusted values by the reservation values from the given config or simply return the API values. I also "simplified" the code functions. This way, we also do not need to re-evaluate the percentage values an can immediately also use it for cpu and disks. Have a nice day and thanks again for this PR! Thanks, |
- Renamed to set_node_resource_reservation
- Immediately apply the values as maxmem for a node
- Avoid recalculating percentage values
- Simplified code
- Adjusted debug logging
gyptazy
force-pushed
the
feature/373-add-resource-reservation-for-nodes
branch
from
636763f to
e0331e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add resource reservation of memory for nodes (by @Chipmonk2)
Comitted by: @Chipmonk2 via #380
Fixes: #373