GH-16678 GLM: Control variables - Multinomial, Ordinal

[maurever]

Issue: #16678

[Copilot]

Pull request overview

This PR implements support for control variables in GLM for multinomial and ordinal families, extending the existing control variables functionality that was previously only available for other GLM families.

Key changes include:

• Added test coverage for control variables with multinomial and ordinal GLM models in R, Python, and Java
• Implemented getControlValBetaMultinomial() method to zero out control variable coefficients in multinomial models
• Updated scoring logic to properly handle control variables in multinomial/ordinal predictions

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
h2o-r/tests/testdir_algos/glm/runit_GLM_control_variables_ordinal.R	New R test for ordinal GLM with control variables
h2o-r/tests/testdir_algos/glm/runit_GLM_control_variables_multinomial.R	New R test for multinomial GLM with control variables
h2o-py/tests/testdir_algos/glm/pyunit_glm_control_variables_ordinal.py	New Python test for ordinal GLM with control variables
h2o-py/tests/testdir_algos/glm/pyunit_glm_control_variables_multinomial.py	New Python test for multinomial GLM with control variables
h2o-algos/src/test/java/hex/glm/GLMControlVariablesTest.java	New Java tests comparing H2O and R implementations for multinomial/ordinal
h2o-algos/src/main/java/hex/glm/GLMScore.java	Updated scoring to apply control variable zeroing for multinomial/ordinal models
h2o-algos/src/main/java/hex/glm/GLMModel.java	Added getControlValBetaMultinomial() method and updated variable importance calculation
h2o-algos/src/main/java/hex/glm/GLM.java	Updated scoring history generation to handle multinomial models with control variables
h2o-algos/src/main/java/hex/api/MakeGLMModelHandler.java	Updated unrestricted model creation to handle multinomial/ordinal models

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[tomasfryda]

Looks good to me. Thank you @maurever !

[tomasfryda]

&& _column_types[featureIdx].equals("Enum")

Is this part really necessary or is it just to be really really sure?