GH-16779: update estimators to support sklearn 1.6+#16780
Open
zazulam wants to merge 1 commit intoh2oai:masterfrom
Open
GH-16779: update estimators to support sklearn 1.6+#16780zazulam wants to merge 1 commit intoh2oai:masterfrom
zazulam wants to merge 1 commit intoh2oai:masterfrom
Conversation
Signed-off-by: zazulam <m.zazula@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16779
Summary
h2o.sklearnwrappers need compatibility updates for newer scikit-learn APIs, especially around estimator type semantics and tags behavior in scikit-learn 1.6+. scikit-learn revamped estimator tags in 1.6.0 (December 2024) and introduced__sklearn_tags__as the preferred API (withTagsobjects). This affects third-party estimator wrappers and type-dispatch behavior (is_classifier,is_regressor, clone/check tooling).For generic H2O sklearn wrappers (e.g.
H2OGradientBoostingEstimator(estimator_type='classifier')), semantics can drift in sklearn integration paths (notably clone + tags/type checks) unless wrapper params and_estimator_typeare propagated consistently.Proposed / implemented fix
In
h2o-py/h2o/sklearn/wrapper.py:_estimator_typeprecedence in classifier/regressor checks.estimator_typeandinit_connection_argsin sklearn parameter flow (get_params/set_params) so clone semantics are preserved.__sklearn_tags__handling for newer sklearn tags API when available.In
h2o-py/tests/testdir_sklearn/pyunit_sklearn_api.py:Validation run
testdir_sklearn/pyunit_sklearn_api.py→ PASStestdir_sklearn/pyunit_sklearn_params.py→ PASSDependency notes