feat(admin): implement FilterChips component and stories#464
feat(admin): implement FilterChips component and stories#464husamettinarabaci merged 2 commits intodevelopfrom
Conversation
husamettinarabaci
left a comment
There was a problem hiding this comment.
Request Changes
Thank you for the comprehensive implementation of the FilterChips component! The code quality is excellent and follows most of our guidelines. However, there is one critical issue that needs to be addressed before merging.
❌ Critical Issue: Non-English Text in Stories
Location: FilterChips.stories.svelte:134
Current Code:
clearAllLabel: 'Filtreleri Temizle'Issue: This contains Turkish text ("Filtreleri Temizle" = "Clear All Filters"), which violates our AGENTS.md English-only policy (lines 26-30).
Required Fix:
clearAllLabel: 'Clear All Filters'📋 Reference
From AGENTS.md:
⚠️ ABSOLUTE REQUIREMENT: All code, comments, documentation, commit messages, PR titles, branch names, and any text within project files MUST BE IN ENGLISH ONLY.
This applies to Storybook stories as well, as they are part of the project files.
✅ What's Already Great
- ✅ Excellent component composition (Text, Button, IconButton, SkeletonLoader)
- ✅ All user-facing strings properly externalized as props with English defaults
- ✅ No custom CSS/styles, proper use of DaisyUI classes
- ✅ TypeScript strict mode compliance
- ✅ Svelte 5 runes ($props, $derived) correctly used
- ✅ Proper branch naming and commit message format
- ✅ Comprehensive Storybook coverage
🎯 Action Required
Please update line 134 in FilterChips.stories.svelte to use English text, then push the changes.
Once this single line is fixed, the PR will be ready to merge! 🚀
📄 Summary
Implemented the
FilterChipscomponent for the admin module using Svelte 5 runes. It provides a visual interface for managing active filters with support for individual removal and clearing all. The implementation follows the library's composition rules by reusingText,IconButton,Button, andSkeletonLoadercore components.🧩 Affected Modules
✅ Checklist
pnpm format)pnpm check) and resolved warnings🔗 Related Issues
Closes #214