Skip to content

feat(admin): implement FilterChips component and stories#464

Merged
husamettinarabaci merged 2 commits intodevelopfrom
feat/admin/filter-chips-issue-214
Jan 25, 2026
Merged

feat(admin): implement FilterChips component and stories#464
husamettinarabaci merged 2 commits intodevelopfrom
feat/admin/filter-chips-issue-214

Conversation

@idris999-c
Copy link
Copy Markdown
Contributor

@idris999-c idris999-c commented Jan 25, 2026

📄 Summary

Implemented the FilterChips component for the admin module using Svelte 5 runes. It provides a visual interface for managing active filters with support for individual removal and clearing all. The implementation follows the library's composition rules by reusing Text, IconButton, Button, and SkeletonLoader core components.


🧩 Affected Modules

  • Source Code
  • Documentation
  • CI / Infra

✅ Checklist

  • My branch name follows format: feat/admin/filter-chips-issue-214
  • My PR title starts with one of the approved types
  • My code is formatted (pnpm format)
  • I ran static analysis (pnpm check) and resolved warnings
  • I ran tests successfully
  • For UI changes, I added Storybook stories
  • I linked related issues using keywords like Closes feat(admin): implement FilterChips component with Storybook stories #214
  • I ensured this PR has no unrelated changes
  • This PR is ready for review and does not include unfinished work

🔗 Related Issues

Closes #214

@idris999-c idris999-c self-assigned this Jan 25, 2026
@github-actions github-actions Bot added the module:source Source Code label Jan 25, 2026
@github-project-automation github-project-automation Bot moved this to 📥 Inbox / Ideas in hexaTune Project Jan 25, 2026
Copy link
Copy Markdown
Member

@husamettinarabaci husamettinarabaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request Changes

Thank you for the comprehensive implementation of the FilterChips component! The code quality is excellent and follows most of our guidelines. However, there is one critical issue that needs to be addressed before merging.


❌ Critical Issue: Non-English Text in Stories

Location: FilterChips.stories.svelte:134

Current Code:

clearAllLabel: 'Filtreleri Temizle'

Issue: This contains Turkish text ("Filtreleri Temizle" = "Clear All Filters"), which violates our AGENTS.md English-only policy (lines 26-30).

Required Fix:

clearAllLabel: 'Clear All Filters'

📋 Reference

From AGENTS.md:

⚠️ ABSOLUTE REQUIREMENT: All code, comments, documentation, commit messages, PR titles, branch names, and any text within project files MUST BE IN ENGLISH ONLY.

This applies to Storybook stories as well, as they are part of the project files.


✅ What's Already Great

  • ✅ Excellent component composition (Text, Button, IconButton, SkeletonLoader)
  • ✅ All user-facing strings properly externalized as props with English defaults
  • ✅ No custom CSS/styles, proper use of DaisyUI classes
  • ✅ TypeScript strict mode compliance
  • ✅ Svelte 5 runes ($props, $derived) correctly used
  • ✅ Proper branch naming and commit message format
  • ✅ Comprehensive Storybook coverage

🎯 Action Required

Please update line 134 in FilterChips.stories.svelte to use English text, then push the changes.

Once this single line is fixed, the PR will be ready to merge! 🚀

@github-project-automation github-project-automation Bot moved this from 📥 Inbox / Ideas to 🚧 In Progress in hexaTune Project Jan 25, 2026
Copy link
Copy Markdown
Member

@husamettinarabaci husamettinarabaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from 🚧 In Progress to Done in hexaTune Project Jan 25, 2026
@husamettinarabaci husamettinarabaci merged commit 603713f into develop Jan 25, 2026
6 checks passed
@husamettinarabaci husamettinarabaci deleted the feat/admin/filter-chips-issue-214 branch January 25, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:source Source Code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants