Open
Conversation
tylerthome
approved these changes
Aug 20, 2025
Member
tylerthome
left a comment
There was a problem hiding this comment.
This looks great, based on everything we discussed this meets exactly what we wanted out of this effort.
A couple of pending items for our discussion this week:
- Styling - let's get in sync with design here, and where it makes sense we can make some styling configs more dynamic and possibly integrated with Figma(etc) tooling
- Using string values for responses as opposed to strict identifiers
- Navigation based on form step - comment in PR
Thanks for the great work here @mugdhchauhan !
|
|
||
| // eslint-disable-next-line no-case-declarations | ||
| const {emailFieldId, phoneFieldId} = field.linkedFields; | ||
| const {emailFieldId, phoneFieldId} = field.linkedFields!; |
Member
There was a problem hiding this comment.
Let's revisit this soon to decide precisely the behavior we want, and if the ! operator meets our needs (as opposed to a more explicit handling of the condition where linkedFields is null
|
|
||
| <Divider sx={{my: 3}} /> | ||
|
|
||
| {step === 1 && ( |
Member
There was a problem hiding this comment.
This could be a good place for an enum to leverage TypeScript to the benefit of code readability, TBD pending discussion, not a blocker for this task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #716
What changes did you make?
Rationale behind the changes?
Testing done for these changes
What did you learn or can share that is new?(optional)
user_idrather than creating duplicate entries.phone_numbernullable./completion-status/{user_id}) to drive frontend UI feedback logic.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied
Screenshots.pdf