Skip to content

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented May 28, 2025

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Modifications / enhancements are reflected on the haddock3 user-manual
  • CHANGELOG.md is updated to incorporate new changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

Adding support to use HETATM from reference file in caprieval module.
This is performed by using an additional parameter: keep_hetatm (default false) in the module allowing to keep HETATM from the input reference file.

Related Issue

Closes #1271

@VGPReys VGPReys requested a review from a team May 29, 2025 07:44
@VGPReys VGPReys self-assigned this May 29, 2025
@VGPReys
Copy link
Contributor Author

VGPReys commented Jun 18, 2025

And do we want the default to be false?

I have no idea.

  • Default true: easier to test a reference structure that contains HETATM(s)
  • Default false: easy to get rid of most of the undesired things from a PDB file (water, ions, ...)

@AnnaKravchenko AnnaKravchenko added m|caprieval Improvements in caprieval module enhancement Improving something in the codebase labels Jul 8, 2025
@VGPReys VGPReys requested a review from a team July 31, 2025 15:10
Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yaml file used "considered" - may-be better to use the same terminology in the code

@VGPReys VGPReys enabled auto-merge August 5, 2025 15:03
@VGPReys VGPReys requested a review from amjjbonvin August 5, 2025 15:03
@VGPReys VGPReys merged commit 26f83e6 into main Aug 5, 2025
9 checks passed
@VGPReys VGPReys deleted the caprieval-hetatm branch August 5, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving something in the codebase m|caprieval Improvements in caprieval module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow references containing HETATM in caprieval
3 participants