Skip to content

Conversation

VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Jul 24, 2025

Summary of the Pull Request

Upgrade PR template and contribution strategies to include the modification of the haddock3 version in the pyproject.toml file.

Related Issue

Closes #1326

@VGPReys VGPReys self-assigned this Jul 24, 2025
@VGPReys VGPReys requested a review from a team July 24, 2025 14:08
@amjjbonvin
Copy link
Member

amjjbonvin commented Jul 25, 2025 via email

@VGPReys VGPReys enabled auto-merge July 29, 2025 07:44
@VGPReys VGPReys added the enhancement Improving something in the codebase label Jul 29, 2025
@VGPReys VGPReys merged commit cbee430 into main Jul 29, 2025
9 checks passed
@VGPReys VGPReys deleted the commit-hash-log branch July 29, 2025 08:00
@rvhonorato
Copy link
Member

This did not update the upload to pypi - you need to change it in a way that every pull-request triggers an upload.

Currently the repository reads version = "2025.07.1" but version on pypi is haddock3 2025.5.0.

Keep in mind the extra 0 that was added here might cause issues with pypi.

@amjjbonvin
Copy link
Member

amjjbonvin commented Jul 31, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving something in the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add version hash code to log file
4 participants