Skip to content

Fix cached-quantity rollback after exceptions#299

Merged
steven-murray merged 2 commits into
mainfrom
fix-92
May 23, 2026
Merged

Fix cached-quantity rollback after exceptions#299
steven-murray merged 2 commits into
mainfrom
fix-92

Conversation

@steven-murray
Copy link
Copy Markdown
Collaborator

@steven-murray steven-murray commented May 23, 2026

Summary

  • make first-time cached quantity evaluation rollback partial cache bookkeeping on exceptions
  • factor the success-path bookkeeping into a helper to keep cache indexing explicit
  • add regressions for recovery after update and full transactional cleanup

Fixes #92

Ensure first-time cached quantity evaluation cleans up partial cache bookkeeping when the underlying calculation raises. Add regressions for both recovery after update and full transactional cleanup.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.86%. Comparing base (14cdf37) to head (d32f74e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   97.83%   97.86%   +0.02%     
==========================================
  Files          26       26              
  Lines        2634     2671      +37     
==========================================
+ Hits         2577     2614      +37     
  Misses         57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Add a regression that exercises failed parent quantity evaluation after touching a subframework so Codecov sees the rollback path.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@steven-murray steven-murray merged commit cc80718 into main May 23, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Re-accessing broken quantity fails

1 participant