fix: replace hardcoded .cuda() with dynamic device inference#1921
Open
Mr-Neutr0n wants to merge 1 commit intohaotian-liu:mainfrom
Open
fix: replace hardcoded .cuda() with dynamic device inference#1921Mr-Neutr0n wants to merge 1 commit intohaotian-liu:mainfrom
Mr-Neutr0n wants to merge 1 commit intohaotian-liu:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
llava/eval/run_llava.py,input_idsis placed on device via a hardcoded.cuda()call (line 111). This breaks inference on non-CUDA devices (MPS, CPU) and can cause device mismatch errors in multi-GPU setups.Notably,
images_tensoron the preceding line already correctly uses.to(model.device, ...), making the hardcoded.cuda()oninput_idsinconsistent.Fix
Replaced
.cuda()with.to(model.device)soinput_idsis placed on the same device as the model, matching the pattern already used forimages_tensor.