fix(ratewise): 收斂 Nitro 設計 token 覆蓋#398
Open
s123104 wants to merge 2 commits into
Open
Conversation
- 補齊 Nitro legacy token、語義色彩 alias 與 focus ring offset，避免設定頁深色主題露出淺底 - 將 html/body 與 critical bootstrap 收斂到語義背景，並讓 applyTheme 同步 critical color-scheme - 新增 changeset、002 獎懲記錄與 token/critical path 漂移防線 測試：focused Vitest、typecheck、Prettier check、build、Chromium/WebKit smoke。
Contributor
Dependency ReviewThe following issues were found:
License Issues.github/workflows/ratewise-production-governance.yml
OpenSSF Scorecard
Scanned Files
|
Contributor
|
✅ SEO 審計通過！所有 2026 標準驗證項目都符合要求。
|
Contributor
Lighthouse Production Baseline ✅
檢查細節
|
s123104
changed the base branch from
main
to
chore/ratewise-production-governance
* fix(ratewise): 收斂支援資訊導覽體驗 - 重構支援與資訊入口為 SSOT 導覽與四語系描述卡片 - 補齊公開頁 safe-area header、行動版 footer 與高對比 active pill token - 同步 SEO 技術頁、Settings skeleton、Guide 錨點與測試 guardrail 測試：pnpm --filter @app/ratewise test -- PageNavHeader Guide Skeleton tokens Settings 測試：pnpm --filter @app/ratewise typecheck 測試：pnpm --filter @app/ratewise build 測試：Playwright Chromium Firefox WebKit iPhone smoke * fix(ratewise): 修正支援導覽路徑比對 - 正規化 PageNavHeader 當前 pathname，讓無 trailing slash 的支援頁仍顯示導覽。 - 補一般與 basename 部署下無 trailing slash 的 active pill 回歸測試。 - 更新 changeset 與 002 稽核記錄，對應 PR404 Codex review thread。 測試：PageNavHeader focused vitest 6 tests、RateWise typecheck。 * fix(ratewise): 收斂支援頁語系水合文案 (#405) * fix(ratewise): 收斂支援頁語系水合文案 - 將支援與資訊頁首屏文案收斂到 supportPages 四語系命名空間。 - 固定 SSG 初始語系，mount 後再同步已儲存的語言偏好。 - 避免 Node navigator 或 localStorage 造成靜態 HTML 與水合文案漂移。 測試：focused vitest、RateWise typecheck、build:ratewise。 測試：pnpm test、pnpm typecheck、Chromium/WebKit mobile smoke。 * fix(ratewise): 收斂熱門幣別導覽 SSOT (#406) - 新增 popular-currency-links，讓首頁、footer、攻略頁與 ItemList 共用熱門幣別清單。 - 修正首頁 SEO section 標籤與桌機 footer 重複內連，並同步 About markdown mirror。 - 更新 SeoTech schema registry 與 002 稽核記錄，加入 changeset。 測試：focused vitest、Footer/首頁 smoke、RateWise typecheck、build:ratewise。 測試：pnpm typecheck、pnpm test、Chromium/WebKit production smoke。 Co-authored-by: haotool <haotool.org@gmail.com> --------- Co-authored-by: haotool <haotool.org@gmail.com> --------- Co-authored-by: haotool <haotool.org@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43866ba2b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
html/body/ critical bootstrap /applyTheme收斂到STYLE_DEFINITIONS與 design token SSOT。驗證
pnpm --filter @app/ratewise test -- src/config/design-tokens.test.ts src/config/__tests__/theme-consistency.test.tspnpm --filter @app/ratewise typecheckpnpm exec prettier --check apps/ratewise/index.html apps/ratewise/tailwind.config.ts apps/ratewise/src/index.css apps/ratewise/src/config/design-tokens.ts apps/ratewise/src/config/design-tokens.test.ts apps/ratewise/src/config/themes.ts .changeset/ratewise-nitro-token-ssot.md docs/dev/002_development_reward_penalty_log.mdpnpm --filter @app/ratewise buildhtml/bodybackground、color-scheme: dark、surface、primary active/ring 與 ring offset。pnpm test、pnpm build:ratewise通過。已知殘留