Skip to content

Conversation

Dorokhov
Copy link

NewRequest accepts interface{} as body argument
but doesn't check it on nil properly. It should
check that not only variable is nil, but also pointer
value is nil. Otherwise it constructs different
Request objects for the same parameters. Tests are
added.

NewRequest accepts interface{} as body argument
but doesn't check it on nil properly. It should
check that not only variable is nil, but also pointer
value is nil. Otherwise it constructs different
Request objects for the same parameters. Tests are
added.
@hashicorp-cla
Copy link

hashicorp-cla commented Jan 28, 2021

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@manicminer manicminer added the bug label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants