Skip to content

make NewRequest accept string #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make NewRequest accept string #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,15 @@ func getBodyReaderAndContentLength(rawBody interface{}) (ReaderFunc, int64, erro
}
contentLength = int64(len(buf))

// If a regular string, we can read it over and over via new
// readers
case string:
buf := body
bodyReader = func() (io.Reader, error) {
return strings.NewReader(buf), nil
}
contentLength = int64(len(buf))

// If a bytes.Buffer we can read the underlying byte slice over and
// over
case *bytes.Buffer:
Expand Down
2 changes: 2 additions & 0 deletions client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,8 @@ func TestClient_Do(t *testing.T) {
// io.ReadSeeker
testClientDo(t, strings.NewReader(string(testBytes)))
// io.Reader
testClientDo(t, string(testBytes))
// io.Reader
testClientDo(t, &custReader{})
}

Expand Down