generated from hashicorp/packer-plugin-scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 125
Add custom user defined/ controlled manual mount command option #603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dwc0011
wants to merge
8
commits into
hashicorp:main
Choose a base branch
from
dwc0011:add-manual-mount-command-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ual mount step, if the command is not empty. Which skips pre/mount/post mount steps.
7fc8b67 to
5475766
Compare
Contributor
Author
|
I am still trying to determine how best to implement an automated test and am open to suggestions. |
9dacb62 to
d835869
Compare
…r should pass it via {{ .MountPath }} referenced in the manual-mount-command configuration to use it
d835869 to
01f84ee
Compare
Contributor
Author
|
@kp2099 @anurag5sh Do you have time to take a look at this functionality and PR and let me know if this is something that you would consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What code changed, and why?
Create a user controlled custom "manual-mount-command" option that when present will run in place of the packer-plugin-amazon's built in mounting steps (pre-mount/mount/post-mount).
Allows the user to define and use a more complicated mounting strategy while packer still manages overall workflow around interacting with the cloud apis and registering/creating images, abstracting that workflow across the different providers.
Resolved Issues
If your PR resolves any open issue(s), please indicate them like this so they will be closed when your PR is merged:
Closes #602
Rollback Plan
If a change needs to be reverted, we will roll out an update to the code within 7 days.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request?
No security control changes.