Skip to content

F aws workspacesweb trust store #43408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 25, 2025
Merged

F aws workspacesweb trust store #43408

merged 11 commits into from
Aug 25, 2025

Conversation

madhavvishnubhatta
Copy link
Contributor

@madhavvishnubhatta madhavvishnubhatta commented Jul 16, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

New resource aws_workspacesweb_trust_store

Relations

Partially addresses #23489

References

Output from Acceptance Testing

% make testacc PKG=workspacesweb TESTS=TestAccWorkSpacesWebTrustStore TESTARGS="-parallel 5"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/workspacesweb/... -v -count 1 -parallel 20 -run='TestAccWorkSpacesWebTrustStore' -parallel 5 -timeout 360m -vet=off
2025/08/07 10:25:34 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/07 10:25:34 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccWorkSpacesWebTrustStore_tags
=== PAUSE TestAccWorkSpacesWebTrustStore_tags
=== RUN   TestAccWorkSpacesWebTrustStore_tags_null
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_null
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyMap
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyMap
=== RUN   TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate
=== RUN   TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_basic
=== PAUSE TestAccWorkSpacesWebTrustStore_basic
=== RUN   TestAccWorkSpacesWebTrustStore_multipleCerts
=== PAUSE TestAccWorkSpacesWebTrustStore_multipleCerts
=== RUN   TestAccWorkSpacesWebTrustStore_disappears
=== PAUSE TestAccWorkSpacesWebTrustStore_disappears
=== RUN   TestAccWorkSpacesWebTrustStore_update
=== PAUSE TestAccWorkSpacesWebTrustStore_update
=== CONT  TestAccWorkSpacesWebTrustStore_tags
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag (45.13s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag (57.81s)
=== CONT  TestAccWorkSpacesWebTrustStore_multipleCerts
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly (60.55s)
=== CONT  TestAccWorkSpacesWebTrustStore_update
--- PASS: TestAccWorkSpacesWebTrustStore_multipleCerts (29.00s)
=== CONT  TestAccWorkSpacesWebTrustStore_disappears
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly (53.98s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate
--- PASS: TestAccWorkSpacesWebTrustStore_disappears (18.06s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag (115.90s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate (31.55s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping
--- PASS: TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace (49.01s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate
--- PASS: TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add (52.76s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping (80.90s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace (59.28s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyMap
--- PASS: TestAccWorkSpacesWebTrustStore_tags (228.59s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate
--- PASS: TestAccWorkSpacesWebTrustStore_update (180.85s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_null
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate (107.92s)
=== CONT  TestAccWorkSpacesWebTrustStore_basic
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyMap (46.48s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping
--- PASS: TestAccWorkSpacesWebTrustStore_tags_null (44.30s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_basic (35.97s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate (71.74s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add (128.07s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag (52.69s)
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag (61.92s)
--- PASS: TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag (77.40s)
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping (134.09s)
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly (80.24s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/workspacesweb      420.037s

@github-actions GitHub Actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/workspacesweb Issues and PRs that pertain to the workspacesweb service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Jul 16, 2025
@madhavvishnubhatta madhavvishnubhatta force-pushed the f-aws_workspacesweb_trust_store branch from 128e285 to 58dd659 Compare July 16, 2025 12:03
@madhavvishnubhatta madhavvishnubhatta marked this pull request as ready for review July 17, 2025 09:12
@madhavvishnubhatta madhavvishnubhatta requested a review from a team as a code owner July 17, 2025 09:12
@madhavvishnubhatta madhavvishnubhatta marked this pull request as draft July 17, 2025 09:17
@madhavvishnubhatta madhavvishnubhatta marked this pull request as ready for review July 17, 2025 13:25
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 21, 2025
@madhavvishnubhatta madhavvishnubhatta force-pushed the f-aws_workspacesweb_trust_store branch from 163fcc7 to 9550b0e Compare August 7, 2025 07:46
@madhavvishnubhatta madhavvishnubhatta mentioned this pull request Aug 8, 2025
Closed
@madhavvishnubhatta madhavvishnubhatta force-pushed the f-aws_workspacesweb_trust_store branch from 9550b0e to d192751 Compare August 11, 2025 09:04
@ewbankkit ewbankkit self-assigned this Aug 23, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 23, 2025
ewbankkit
ewbankkit previously approved these changes Aug 23, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccWorkSpacesWebTrustStore_' PKG=workspacesweb ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/workspacesweb/... -v -count 1 -parallel 3  -run=TestAccWorkSpacesWebTrustStore_ -timeout 360m -vet=off
2025/08/23 17:25:34 Creating Terraform AWS Provider (SDKv2-style)...
2025/08/23 17:25:34 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccWorkSpacesWebTrustStore_tags
=== PAUSE TestAccWorkSpacesWebTrustStore_tags
=== RUN   TestAccWorkSpacesWebTrustStore_tags_null
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_null
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyMap
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyMap
=== RUN   TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate
=== RUN   TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccWorkSpacesWebTrustStore_basic
=== PAUSE TestAccWorkSpacesWebTrustStore_basic
=== RUN   TestAccWorkSpacesWebTrustStore_multipleCerts
=== PAUSE TestAccWorkSpacesWebTrustStore_multipleCerts
=== RUN   TestAccWorkSpacesWebTrustStore_disappears
=== PAUSE TestAccWorkSpacesWebTrustStore_disappears
=== RUN   TestAccWorkSpacesWebTrustStore_update
=== PAUSE TestAccWorkSpacesWebTrustStore_update
=== CONT  TestAccWorkSpacesWebTrustStore_tags
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyProviderOnlyTag (27.35s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_emptyResourceTag (31.87s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToResourceOnly (45.39s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccWorkSpacesWebTrustStore_tags (120.15s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_providerOnly (144.98s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_updateToProviderOnly (47.11s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_overlapping (80.94s)
=== CONT  TestAccWorkSpacesWebTrustStore_update
--- PASS: TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_DefaultTag (59.40s)
=== CONT  TestAccWorkSpacesWebTrustStore_disappears
--- PASS: TestAccWorkSpacesWebTrustStore_disappears (28.06s)
=== CONT  TestAccWorkSpacesWebTrustStore_multipleCerts
--- PASS: TestAccWorkSpacesWebTrustStore_multipleCerts (25.07s)
=== CONT  TestAccWorkSpacesWebTrustStore_basic
--- PASS: TestAccWorkSpacesWebTrustStore_update (65.50s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nonOverlapping (146.56s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate
--- PASS: TestAccWorkSpacesWebTrustStore_basic (29.98s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnCreate (25.24s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccWorkSpacesWebTrustStore_tags_IgnoreTags_Overlap_ResourceTag (90.81s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Replace (64.45s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate
--- PASS: TestAccWorkSpacesWebTrustStore_tags_ComputedTag_OnUpdate_Add (44.11s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullNonOverlappingResourceTag (23.00s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnCreate (47.40s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyMap
--- PASS: TestAccWorkSpacesWebTrustStore_tags_DefaultTags_nullOverlappingResourceTag (33.43s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Add (80.25s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_null
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyMap (37.61s)
=== CONT  TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccWorkSpacesWebTrustStore_tags_AddOnUpdate (48.05s)
--- PASS: TestAccWorkSpacesWebTrustStore_tags_null (28.86s)
--- PASS: TestAccWorkSpacesWebTrustStore_tags_EmptyTag_OnUpdate_Replace (49.14s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/workspacesweb	498.254s

jar-b
jar-b previously approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit dismissed stale reviews from jar-b and themself via ccd5b9f August 25, 2025 13:44
jar-b
jar-b approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@madhavvishnubhatta Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 9ded5e4 into hashicorp:main Aug 25, 2025
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.11.0 milestone Aug 25, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v6.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

@ewbankkit ewbankkit ewbankkit left review comments

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. partner Contribution from a partner. service/workspacesweb Issues and PRs that pertain to the workspacesweb service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@madhavvishnubhatta @ewbankkit @jar-b @justinretzolk