Skip to content

Conversation

dacohen
Copy link
Contributor

@dacohen dacohen commented Jul 18, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR adds the authentication_method and service_access_role_arn settings to the postgres_settings block for aws_dms_endpoint. These are necessary for using IAM authentication with a DMS Endpoint.

Relations

Closes #43289

References

Output from Acceptance Testing

% make testacc TESTS=TestAccDMSEndpoint_PostgreSQL_settings PKG=dms

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_PostgreSQL_settings'  -timeout 360m -vet=off
2025/07/17 23:15:15 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/17 23:15:15 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_source
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_source
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_target
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_target
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_source
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_target
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_target (123.34s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_source (123.71s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        128.146s

…s_settings` in `aws_dms_endpoint` resource.
@dacohen dacohen requested a review from a team as a code owner July 18, 2025 03:18
Copy link
Contributor

github-actions bot commented Jul 18, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/dms Issues and PRs that pertain to the dms service. size/S Managed by automation to categorize the size of a PR. labels Jul 18, 2025
@github-actions github-actions bot added the size/M Managed by automation to categorize the size of a PR. label Jul 18, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 22, 2025
@ewbankkit ewbankkit self-assigned this Jul 22, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 22, 2025
ewbankkit
ewbankkit previously approved these changes Jul 22, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccDMSEndpoint_PostgreSQL\|TestAccDMSEndpointDataSource_basic' PKG=dms ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/dms/... -v -count 1 -parallel 3  -run=TestAccDMSEndpoint_PostgreSQL\|TestAccDMSEndpointDataSource_basic -timeout 360m -vet=off
2025/07/22 10:59:26 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/22 10:59:26 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN   TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN   TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN   TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_source
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_source
=== RUN   TestAccDMSEndpoint_PostgreSQL_settings_target
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_target
=== CONT  TestAccDMSEndpointDataSource_basic
=== CONT  TestAccDMSEndpoint_PostgreSQL_kmsKey
=== CONT  TestAccDMSEndpoint_PostgreSQL_secretID
--- PASS: TestAccDMSEndpointDataSource_basic (26.16s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_target
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (29.68s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_settings_source
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (35.46s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_source (18.11s)
=== CONT  TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_target (24.00s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (20.03s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (34.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	75.296s

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@dacohen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 723110f into hashicorp:main Jul 22, 2025
45 checks passed
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.5.0 milestone Jul 22, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 24, 2025
Copy link
Contributor

This functionality has been released in v6.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. size/M Managed by automation to categorize the size of a PR. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IAM Authentication on aws_dms_endpoint
3 participants