-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Add authentication_method and service_access_role_arn to postgres_settings for aws_dms_endpoint #43440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authentication_method and service_access_role_arn to postgres_settings for aws_dms_endpoint #43440
Conversation
…s_settings` in `aws_dms_endpoint` resource.
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccDMSEndpoint_PostgreSQL\|TestAccDMSEndpointDataSource_basic' PKG=dms ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/dms/... -v -count 1 -parallel 3 -run=TestAccDMSEndpoint_PostgreSQL\|TestAccDMSEndpointDataSource_basic -timeout 360m -vet=off
2025/07/22 10:59:26 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/22 10:59:26 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccDMSEndpointDataSource_basic
=== PAUSE TestAccDMSEndpointDataSource_basic
=== RUN TestAccDMSEndpoint_PostgreSQL_basic
=== PAUSE TestAccDMSEndpoint_PostgreSQL_basic
=== RUN TestAccDMSEndpoint_PostgreSQL_secretID
=== PAUSE TestAccDMSEndpoint_PostgreSQL_secretID
=== RUN TestAccDMSEndpoint_PostgreSQL_update
=== PAUSE TestAccDMSEndpoint_PostgreSQL_update
=== RUN TestAccDMSEndpoint_PostgreSQL_kmsKey
=== PAUSE TestAccDMSEndpoint_PostgreSQL_kmsKey
=== RUN TestAccDMSEndpoint_PostgreSQL_settings_source
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_source
=== RUN TestAccDMSEndpoint_PostgreSQL_settings_target
=== PAUSE TestAccDMSEndpoint_PostgreSQL_settings_target
=== CONT TestAccDMSEndpointDataSource_basic
=== CONT TestAccDMSEndpoint_PostgreSQL_kmsKey
=== CONT TestAccDMSEndpoint_PostgreSQL_secretID
--- PASS: TestAccDMSEndpointDataSource_basic (26.16s)
=== CONT TestAccDMSEndpoint_PostgreSQL_settings_target
--- PASS: TestAccDMSEndpoint_PostgreSQL_secretID (29.68s)
=== CONT TestAccDMSEndpoint_PostgreSQL_settings_source
--- PASS: TestAccDMSEndpoint_PostgreSQL_kmsKey (35.46s)
=== CONT TestAccDMSEndpoint_PostgreSQL_update
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_source (18.11s)
=== CONT TestAccDMSEndpoint_PostgreSQL_basic
--- PASS: TestAccDMSEndpoint_PostgreSQL_settings_target (24.00s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_basic (20.03s)
--- PASS: TestAccDMSEndpoint_PostgreSQL_update (34.97s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 75.296s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@dacohen Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v6.5.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
This PR adds the
authentication_method
andservice_access_role_arn
settings to thepostgres_settings
block foraws_dms_endpoint
. These are necessary for using IAM authentication with a DMS Endpoint.Relations
Closes #43289
References
Output from Acceptance Testing