-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Enhancement] aws_codebuild_fleet: Support custom instance type in the fleet #43449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] aws_codebuild_fleet: Support custom instance type in the fleet #43449
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
5e4ed11
to
8711b4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodeBuildFleet' PKG=codebuild ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.5 test ./internal/service/codebuild/... -v -count 1 -parallel 3 -run=TestAccCodeBuildFleet -timeout 360m -vet=off
2025/07/29 16:55:06 Creating Terraform AWS Provider (SDKv2-style)...
2025/07/29 16:55:06 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccCodeBuildFleetDataSource_basic
=== PAUSE TestAccCodeBuildFleetDataSource_basic
=== RUN TestAccCodeBuildFleetDataSource_customInstanceType
=== PAUSE TestAccCodeBuildFleetDataSource_customInstanceType
=== RUN TestAccCodeBuildFleet_Identity_Basic
=== PAUSE TestAccCodeBuildFleet_Identity_Basic
=== RUN TestAccCodeBuildFleet_Identity_RegionOverride
=== PAUSE TestAccCodeBuildFleet_Identity_RegionOverride
=== RUN TestAccCodeBuildFleet_Identity_ExistingResource
=== PAUSE TestAccCodeBuildFleet_Identity_ExistingResource
=== RUN TestAccCodeBuildFleet_basic
=== PAUSE TestAccCodeBuildFleet_basic
=== RUN TestAccCodeBuildFleet_disappears
=== PAUSE TestAccCodeBuildFleet_disappears
=== RUN TestAccCodeBuildFleet_tags
=== PAUSE TestAccCodeBuildFleet_tags
=== RUN TestAccCodeBuildFleet_baseCapacity
=== PAUSE TestAccCodeBuildFleet_baseCapacity
=== RUN TestAccCodeBuildFleet_computeConfiguration
=== PAUSE TestAccCodeBuildFleet_computeConfiguration
=== RUN TestAccCodeBuildFleet_computeType
=== PAUSE TestAccCodeBuildFleet_computeType
=== RUN TestAccCodeBuildFleet_environmentType
=== PAUSE TestAccCodeBuildFleet_environmentType
=== RUN TestAccCodeBuildFleet_imageId
=== PAUSE TestAccCodeBuildFleet_imageId
=== RUN TestAccCodeBuildFleet_scalingConfiguration
=== PAUSE TestAccCodeBuildFleet_scalingConfiguration
=== RUN TestAccCodeBuildFleet_vpcConfig
=== PAUSE TestAccCodeBuildFleet_vpcConfig
=== RUN TestAccCodeBuildFleet_customInstanceType
=== PAUSE TestAccCodeBuildFleet_customInstanceType
=== CONT TestAccCodeBuildFleetDataSource_basic
=== CONT TestAccCodeBuildFleet_baseCapacity
=== CONT TestAccCodeBuildFleet_Identity_ExistingResource
--- PASS: TestAccCodeBuildFleetDataSource_basic (42.99s)
=== CONT TestAccCodeBuildFleet_tags
--- PASS: TestAccCodeBuildFleet_baseCapacity (66.02s)
=== CONT TestAccCodeBuildFleet_disappears
=== CONT TestAccCodeBuildFleet_basic
--- PASS: TestAccCodeBuildFleet_Identity_ExistingResource (111.52s)
--- PASS: TestAccCodeBuildFleet_disappears (56.89s)
=== CONT TestAccCodeBuildFleet_Identity_Basic
--- PASS: TestAccCodeBuildFleet_tags (87.86s)
=== CONT TestAccCodeBuildFleet_Identity_RegionOverride
--- PASS: TestAccCodeBuildFleet_basic (43.65s)
=== CONT TestAccCodeBuildFleet_imageId
--- PASS: TestAccCodeBuildFleet_Identity_Basic (50.78s)
=== CONT TestAccCodeBuildFleet_customInstanceType
--- PASS: TestAccCodeBuildFleet_Identity_RegionOverride (54.38s)
=== CONT TestAccCodeBuildFleet_vpcConfig
--- PASS: TestAccCodeBuildFleet_imageId (43.75s)
=== CONT TestAccCodeBuildFleet_scalingConfiguration
--- PASS: TestAccCodeBuildFleet_customInstanceType (66.84s)
=== CONT TestAccCodeBuildFleetDataSource_customInstanceType
--- PASS: TestAccCodeBuildFleetDataSource_customInstanceType (41.48s)
=== CONT TestAccCodeBuildFleet_computeType
--- PASS: TestAccCodeBuildFleet_scalingConfiguration (90.54s)
=== CONT TestAccCodeBuildFleet_environmentType
--- PASS: TestAccCodeBuildFleet_vpcConfig (125.14s)
=== CONT TestAccCodeBuildFleet_computeConfiguration
--- PASS: TestAccCodeBuildFleet_computeType (64.81s)
--- PASS: TestAccCodeBuildFleet_environmentType (64.36s)
--- PASS: TestAccCodeBuildFleet_computeConfiguration (66.91s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codebuild 382.400s
@tabito-hara Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v6.7.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
instance_type
argument to thecompute_configuration
block of theaws_codebuild_fleet
resource, as well as to theaws_codebuild_fleet
data source, to support custom instance types in fleets.Relations
Closes #43384
References
https://docs.aws.amazon.com/codebuild/latest/APIReference/API_CreateFleet.html
Output from Acceptance Testing