Skip to content

Conversation

rhariady
Copy link

@rhariady rhariady commented Sep 1, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

No

Description

Add 2 new optionals attribute for aws_key_pair resource.

  • public_key_wo (write only)
  • public_key_wo_version

Only one of public_key or public_key_wo can be set, and this is ensured by using the ExactlyOneOf parameter.

Relations

Closes #41922

References

Output from Acceptance Testing

% make testacc TESTS=TestAccEC2KeyPair_basic PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2KeyPair_basic'  -timeout 360m -vet=off
2025/09/01 14:40:44 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/01 14:40:44 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2KeyPair_basic
=== PAUSE TestAccEC2KeyPair_basic
=== CONT  TestAccEC2KeyPair_basic
--- PASS: TestAccEC2KeyPair_basic (21.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        21.735s


% make testacc TESTS=TestAccEC2KeyPair_writeOnly PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.6 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2KeyPair_writeOnly'  -timeout 360m -vet=off
2025/09/01 14:18:22 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/01 14:18:22 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccEC2KeyPair_writeOnly
=== PAUSE TestAccEC2KeyPair_writeOnly
=== CONT  TestAccEC2KeyPair_writeOnly
--- PASS: TestAccEC2KeyPair_writeOnly (23.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        23.900s
...

@rhariady rhariady requested a review from a team as a code owner September 1, 2025 07:29
Copy link
Contributor

github-actions bot commented Sep 1, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

Copy link
Contributor

github-actions bot commented Sep 1, 2025

✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. labels Sep 1, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Implementation of write-only arguments in aws_key_pair
2 participants