Skip to content

list/combined framework/sdkv2 implementations #44147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 135 commits into
base: main
Choose a base branch
from
Draft

list/combined framework/sdkv2 implementations #44147

wants to merge 135 commits into from
+4,232 −1,441

Conversation

johnsonaj
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Initial implementation on resources that support list operation

  • aws_batch_job_queue
  • aws_cloudwatch_log_group

Relations

Relates #43960
Relates #44129

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

gdavison and others added 30 commits August 19, 2025 16:28
@gdavison
Updates dependencies
58418b5
@gdavison
Consolidates interceptedHandler tests
f4df5ef
@gdavison
Adds ListResource interceptors and handles Before interceptors
3c6effd
@gdavison
Handles successful inner function
2d123e4
@gdavison
Handles errors on inner function
f48273d
@gdavison
Creates iter.Null
94def71
@gdavison
Renames listResourceSchemaInterceptor schema function
4488add
@gdavison
Adds region interceptor for List Resources
0628d91
@gdavison
Adds types.ServicePackageListResource
737f235
@gdavison
Adds tests for AssertSingleValueResult
da4d2ff
@gdavison
Adds AssertSingleValueResultIterErr
f778a0a
@gdavison
Adds iter.Null2
8cac22c
@gdavison
Adds shared List Resource region attribute
271e0f3
@gdavison
Adds default region interceptor for List Resources
0447e94
@gdavison
Adds Identity to List Resource spec
60ffb86
@gdavison
Adds iterator listJobQueues
37d3837
@gdavison
Removes unused default region interceptor
5d6f7e6
@gdavison
Uses listJobQueues for sweeper
6de36ba
@gdavison
Updates dependencies
4a7b622
@gdavison
Renames inttypes.ServicePackageListResource to `ServicePackageFrame…
6a1ad30 
…workListResource`
@gdavison
Adds Tags to ServicePackageFrameworkResource
daa1d7f
@gdavison
Updates github.com/hashicorp/terraform-plugin-testing dependency
e706526
@gdavison
Adds WIP List code for aws_batch_job_queue
ad4c9d9
@gdavison
Registers List Resource for aws_batch_job_queue
e0cd63d
@gdavison
WIP acceptance tests
b8d6e8b
@gdavison
Manual test configurations
ff7a725
@gdavison
Formatting
47e53f6
@gdavison
Updates github.com/hashicorp/terraform-plugin-framework
8845b72
@johnsonaj
deps
1f52bb0
@johnsonaj
copy setup
d2c8037
johnsonaj and others added 28 commits September 8, 2025 15:00
@johnsonaj @gdavison
refactor to simplify resued method
b3f8f71
@johnsonaj @gdavison
make gen
0da04aa
@gdavison
Moves list implementation
0c9044a
@gdavison
Centralizes flattening
9602c05
@gdavison
Returns iterator for listInstances
bdfd9df
@gdavison
Moves find functions to resource source file
f757802
@gdavison
Cleanup
2597025
@gdavison
Handles value from id in List Identity
4d509c9
@gdavison
Syncs SDKv2 List Identity hander with SDKv2 Identity interceptor
da84d9d
@gdavison
Passes meta to readBlockDevices as *conns.AWSClient instead of …
1fc1966 
…`any`
@gdavison
Factors out flattening aws_instance
2458db0
@gdavison
Adds List support for aws_instance
1b382ab
@gdavison
Adds ListResourceForSDK type
b09015e
@gdavison
Renaming functions on ListResourceWithSDKv2Resource
73182df
@gdavison
Moves resource data initialization to ListResourceWithSDKv2Resource
4972618
@gdavison
Moves populating Result to ListResourceWithSDKv2Resource
3c1e2f7
@gdavison
Only returns resource data if requested
3bc82ed
@gdavison
Semgrep
6c601c6
@gdavison
Linting fix
c2dcb8a
@gdavison
terraform fmt
0207078
@gdavison
copywrite
92107ac
@gdavison
Linting fix
079fcab
@gdavison
Handles resourceInstanceFlatten errors
d42099f
@gdavison
Updates github.com/hashicorp/terraform-plugin-testing
b7d9c73
@gdavison
Adds basic list test for aws_cloudwatch_log_group
d9c2f94
@gdavison
Adds basic list test for aws_instance
f36dda8
@gdavison
Adds filter to aws_instance List
d305487
@gdavison
Merge branch 'f-list_sdkv2' into f-list_framework_sdk_combined
e65ef78
@github-actions github-actions bot added the service/ec2 Issues and PRs that pertain to the ec2 service. label Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. service/batch Issues and PRs that pertain to the batch service. service/ec2 Issues and PRs that pertain to the ec2 service. service/logs Issues and PRs that pertain to the logs service. size/XL Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnsonaj @gdavison