Skip to content

Conversation

auvred
Copy link
Contributor

@auvred auvred commented Sep 6, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

AWS_IAM is a valid auth provider type.

I copied the order of possible values from here for better consistency:

### Auth Modes
The `connection_auth_mode`, `default_publish_auth_mode`, and `default_subscribe_auth_mode` blocks support the following:
* `auth_type` - (Required) Type of authentication. Valid values: `API_KEY`, `AWS_IAM`, `AMAZON_COGNITO_USER_POOLS`, `OPENID_CONNECT`, `AWS_LAMBDA`.

References

https://docs.aws.amazon.com/appsync/latest/APIReference/API_AuthProvider.html#appsync-Type-AuthProvider-authType

@auvred auvred requested a review from a team as a code owner September 6, 2025 14:30
Copy link
Contributor

github-actions bot commented Sep 6, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/appsync Issues and PRs that pertain to the appsync service. size/XS Managed by automation to categorize the size of a PR. labels Sep 6, 2025
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Sep 8, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jar-b
Copy link
Member

jar-b commented Sep 8, 2025

Thank you for the correction, @auvred! 🔍

@jar-b jar-b merged commit e67e508 into hashicorp:main Sep 8, 2025
25 checks passed
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.13.0 milestone Sep 8, 2025
Copy link
Contributor

This functionality has been released in v6.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

marcinbelczewski pushed a commit to marcinbelczewski/terraform-provider-aws that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/appsync Issues and PRs that pertain to the appsync service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants