Update key_prefix resource to only write updated keys#456
Open
mbillow wants to merge 1 commit intohashicorp:mainfrom
Open
Update key_prefix resource to only write updated keys#456mbillow wants to merge 1 commit intohashicorp:mainfrom
mbillow wants to merge 1 commit intohashicorp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently the
consul_key_prefixresource reads all of the keys from Consul, compares this against the provided configuration, and rewrites all of the existing keys whether they have been updated or not. This is causes a large amount of needless writes when the resource is used to manage keys at scale. This change simply adds validation if asubkeyor items in thesubkeysmap are in the correct state and skips them in the update stage.This change also makes the change plans that Terraform generates match the eventual API calls made to Consul.
Previously, this change actually made 9 API calls, now it properly makes 2, like the plan suggests:
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.