ブックマークとコメントにキーボードだけ(tab + enter)でフォーカスできるようにする#17
Open
kei-sato wants to merge 10 commits intohatena:devfrom
Open
ブックマークとコメントにキーボードだけ(tab + enter)でフォーカスできるようにする#17kei-sato wants to merge 10 commits intohatena:devfrom
kei-sato wants to merge 10 commits intohatena:devfrom
Conversation
version 1.4.3
kei-sato
force-pushed
the
focus-tab-with-keyboard
branch
from
3f16522 to
0b641ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
動機
はてなブックマークのchrome extensionにはいつもお世話になっています。
基本的には使いやすいのですが、普段ブラウジングしている時にほとんどキーボードから手を離さないので、はてなブックマークのchrome extensionを開いた時に検索にフォーカスがあると、わざわざマウス（トラックパッド）を触ってブックマークタブにフォーカスを合わせるのが億劫でした。
なので、キーボードだけでタブにフォーカスを合わせられるようにするための変更をさせていただきました。
修正内容
aタグを使うことでフォーカス対象にしました。
aタグのclickイベントをそのまま親に受け流しています。