adjust logging for extracting oci artifacts with cosign bits#575
Merged
zackbradys merged 1 commit intohauler-dev:mainfrom Apr 22, 2026
Merged
adjust logging for extracting oci artifacts with cosign bits#575zackbradys merged 1 commit intohauler-dev:mainfrom
zackbradys merged 1 commit intohauler-dev:mainfrom
Conversation
Signed-off-by: Adam Martin <adam.martin@ranchergovernment.com>
zackbradys
approved these changes
Apr 22, 2026
Member
|
/cherrypick-2.0 |
|
🏷️ Labeled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check below, if the PR fulfills these requirements:
Associated Links:
Types of Changes:
Proposed Changes:
hauler store extractwalks every descriptor in the store's index whose reference contains the target repo prefix. Cosign sig/att/sbom/referrer descriptors share that prefix, so they get decoded as manifests and fed into the container-image heuristic (isContainerImageManifest), which trips on their config media type and produces:That warning is both wrong (the artifact is a signature, not an image) and noise (signatures are registry-only metadata — not extractable by design, and not something the user asked for).
This change adds a
kind-annotation early-return at the top of the extract walk callback, mirroring the existing pattern incmd/hauler/cli/store/copy.gofor directory targets. Sig/att/sbom/referrer descriptors are now skipped silently(logged at debug level). The
container images cannot be extractedwarning is unchanged and still fires for legitimate container-image refs.cmd/hauler/cli/store/extract.go— skip descriptors whosekindannotation isdev.hauler/sigs,/atts,/sboms, or has thedev.hauler/referrers/prefix, before the container-image heuristic runs.Verification/Testing of Changes:
Additional Context: