Log also the first state #5
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thank you very much for your nice work and for releasing the weights of the model.
When I tested your repository and the nice web UI,
it turned out that the very first step (Step 0) is not recorded in the trajectory file nor in the web ui.
The error message was:
Agent state missing trajectory_id, cannot route event
.I checked it and saw that in
surferh.py
in theagent_loop
function theAgentState
is created but only set to thethreading.local()
object via functionset_current_state
in functionupdate_state
.This
update_state
function is only called at the end of the `agent_loop' function, and thus, the first step is not recorded.I added a call to the
set_current_state
after generating the initialAgentState
.Furthermore, when I called the
run-on-holo1.sh
script with a local hosted model, there was an error message from Selenium.Thus, I added the option
--headless-browser
in this script as well.Please review my changes, and if you are fine with them, I would be happy if it is included.
Best regards
Sven