Skip to content

Conversation

sven-h
Copy link

@sven-h sven-h commented Aug 1, 2025

Hi,

thank you very much for your nice work and for releasing the weights of the model.
When I tested your repository and the nice web UI,
it turned out that the very first step (Step 0) is not recorded in the trajectory file nor in the web ui.
The error message was: Agent state missing trajectory_id, cannot route event.

I checked it and saw that in surferh.py in the agent_loop function the AgentState is created but only set to the threading.local() object via function set_current_state in function update_state.
This update_state function is only called at the end of the `agent_loop' function, and thus, the first step is not recorded.

I added a call to the set_current_state after generating the initial AgentState.

Furthermore, when I called the run-on-holo1.sh script with a local hosted model, there was an error message from Selenium.
Thus, I added the option --headless-browser in this script as well.

Please review my changes, and if you are fine with them, I would be happy if it is included.

Best regards
Sven

@sven-h
Copy link
Author

sven-h commented Aug 5, 2025

I noticed that run-on-holo1.sh should be used for live agent clicking. Thus, I reverted my change here.
But the update_state function should still be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant