feat: add pre-commit hook and enforce strict types across files#68
Merged
danielhe4rt merged 2 commits into3.xfrom Oct 30, 2025
Merged
Conversation
- add pre-commit hook for linting - declare strict types in multiple PHP files - update composer.json and package.json for new dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements across the codebase, focusing on enforcing stricter typing, enhancing immutability, and standardizing code style. The changes primarily affect the authentication and character modules, with additional updates to code formatting and development tooling.
Code Quality and Type Safety Improvements:
declare(strict_types=1);to the top of multiple PHP files across theHeart/Authentication/OAuthandHeart/Characterdomains to enforce strict type checking.finaland/orreadonlyclasses to improve immutability and prevent unintended inheritance or modification.Development Tooling and Code Style:
.prettierrcand.prettierignorefiles to enforce consistent code formatting, including support for Blade and Tailwind CSS plugins..editorconfigto set tab indentation for Makefiles and.mkfiles, replacing previous docker-compose-specific settings..husky/pre-commithook to runlint-stagedbefore commits, helping catch formatting issues early.Workflow and Environment Consistency:
These changes collectively enhance code reliability, maintainability, and developer experience across the project.