feat: move season domain to modular convention#70
Closed
Conversation
adds pest-plugin-drift to streamline refactoring to pest testing
- add he4rt/season as a new dependency - update dependency he4rt/badge to 1.0.0 - update dependency laravel/framework to 12.36.1
- move season-related classes to a modular structure - update ns for SeasonFactory, SeasonRepository, and related classes - add season routes for retrieving current and all seasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the Season module to a new PSR-4-compliant structure under the
app-modules/seasondirectory, updating namespaces, file locations, and autoloading accordingly. It also introduces a newcomposer.jsonfor modular loading, updates service providers, and refactors model, factory, and seeder locations. The changes modernize the module, improve maintainability, and ensure compatibility with Laravel's package discovery.Module Restructuring and Namespace Updates:
Migrated all Season module files from the
Heart\Seasonnamespace toHe4rt\Season, updating all class references and file locations to match PSR-4 standards.Replaced the old service provider and route provider with a new
SeasonServiceProviderin the correct namespace and location, and moved route definitions to a dedicatedroutes/season-routes.phpfile.Autoloading and Composer Integration:
composer.jsoninapp-modules/seasonto define PSR-4 autoloading for source, tests, factories, and seeders, and to enable Laravel package discovery for the new service provider.Factories and Seeders Refactoring:
SeasonFactoryandSeasonSeederto the new structure and namespaces, ensuring compatibility with the new model location and autoloading.Testing Improvements:
GetCurrentSeasonTestto verify the endpoint for fetching the current season, improving test coverage.Domain Layer Cleanup: