Skip to content

chore(bot-discord): link libdave for voice#410

Merged
gvieira18 merged 1 commit into
4.xfrom
chore/libdave-voice-setup
Jul 10, 2026
Merged

chore(bot-discord): link libdave for voice#410
gvieira18 merged 1 commit into
4.xfrom
chore/libdave-voice-setup

Conversation

@gvieira18

Copy link
Copy Markdown
Member

Summary

  • Add a make libdave target that symlinks the libdave (DAVE E2EE) install into the .cache/libdave probe path, so the Discord bot boots without the failed to initialize voice class / LibDaveNotFoundException error (DAVE is mandatory for voice since 2026-03-01).
  • Symlinking the probe path avoids relying on DISCORDPHP_DAVE_LIBRARY, which the Forge daemon (Supervisor ignores shell rc) and config:cache (skips .env) both defeat.
  • gitignore /.cache (machine-local, like /vendor).

Deploy: run make libdave after composer install in the Forge deploy script.

@gvieira18 gvieira18 requested a review from a team July 9, 2026 23:56
Voice connections need libdave (DAVE E2EE, mandatory since
2026-03-01); link it into the .cache/libdave probe path so the
bot boots without the env var that Supervisor/config:cache defeat.
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a5894813-bb4a-4870-a908-c869488535d3

📥 Commits

Reviewing files that changed from the base of the PR and between bd6d183 and f21ab17.

📒 Files selected for processing (2)
  • .gitignore
  • Makefile
🚧 Files skipped from review as they are similar to previous changes (2)
  • .gitignore
  • Makefile

📝 Walkthrough

Walkthrough

Adds a libdave Makefile target that creates .cache and symlinks the configured libdave directory into .cache/libdave. Adds /.cache to .gitignore so generated cache contents are ignored.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding libdave linking for Discord bot voice.
Description check ✅ Passed The description accurately describes the libdave target, .cache symlink, and gitignore update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gvieira18 gvieira18 force-pushed the chore/libdave-voice-setup branch from bd6d183 to f21ab17 Compare July 9, 2026 23:59
@gvieira18 gvieira18 merged commit fb8912a into 4.x Jul 10, 2026
9 checks passed
@gvieira18 gvieira18 deleted the chore/libdave-voice-setup branch July 10, 2026 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant