Open
Conversation
1) adding week day names dictionary(hebrew and english).
2) adding 4 string functions , spread them from toString function.
1) getDayName - getting the hebrew day
2) getMonthName - getting the hebrew month
3) getYearName - getting the hebrew year.
4)
3) adding method to get the name of week day.
4) adding method dateFormat - with date formatter u can get the date with any format you need.
usage :
let hebCalObj = new Hebcal();
let hebrewDateObj = (hebCalObj).find(new Date)[0];
if (hebrewDateObj){
weekDay = 'יום ' + hebrewDateObj.getWeekDayName(lang);
hebrewDate = hebrewDateObj.dateFormat('D M',lang);
}
|
I like this idea. |
Scimonster
reviewed
Sep 16, 2019
Scimonster
reviewed
Sep 16, 2019
Contributor
|
I like this idea. I left a couple comments with issues. (And sorry for taking so long to respond.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usage :
let hebCalObj = new Hebcal();
let hebrewDateObj = (hebCalObj).find(new Date)[0];
if (hebrewDateObj){
weekDay = 'יום ' + hebrewDateObj.getWeekDayName(lang);
hebrewDate = hebrewDateObj.dateFormat('D M',lang);
}