- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 553
Test suite #3568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            jasonahjie
  wants to merge
  18
  commits into
  master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
test-suite
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            Test suite #3568
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    * Fix ServiceCommandTest * Added StringConverter, formGenerator, routeProvider
* Rename and move tests classes to match class and package names of its subjects under test. * Add keys to the arrays in the data providers methods.
* Rename and Move ConfigFormBaseCommandTest Rename GeneratorConfigFormBaseCommandTest.php located in Command and moved it to Generate as ConfigFormBaseCommandTest.php * Rename and move ControllerCommandTest Renamed GeneratorControllerCommandTest.php located in Command and moved it to Generate as ControllerCommandTest.php * Rename and move EntityCommandTest Renamed GeneratorEntityCommandTest.php located in Command and moved it to Generate as EntityCommandTest.php * Rename and move EntityConfigCommandTest Renamed GeneratorEntityConfigCommandTest.php located in Command and moved it to Generate as EntityConfigCommandTest.php * Rename and move EntityContentCommandTest Renamed GeneratorEntityContentCommandTest.php located in Command and moved it to Generate as EntityCommandCommandTest.php * Rename and move FormCommandTest Renamed GeneratorFormCommandTest.php located in Command and moved it to Generate as FormCommandTest.php * Rename and move ModuleCommandTest Renamed GeneratorModuleCommandTest.php located in Command and moved it to Generate as ModuleCommandTest.php * Rename PermissionCommandTest Renamed GeneratorPermissionCommandTest.php located in Command and moved it to Generate as PermissionCommandTest.php * Rename and move PluginBlockCommandTest Renamed GeneratorPluginBlockCommandTest.php located in Command and moved it to Generate as PluginBlockCommandTest.php * Rename and move PluginConditionCommandTest Renamed GeneratorPluginConditionCommandTest.php located in Command and moved it to Generate as PluginConditionCommandTest.php * Rename and move PluginFieldCommandTest Renamed GeneratorPluginFieldCommandTest.php located in Command and moved it to Generate as PluginFieldCommandTest.php * Rename PluginFieldFormatter Renamed GeneratorPluginFieldFormatterCommandTest.php located in Command and moved it to Generate as PluginFieldFormatterCommandTest.php * Rename and move PluginFieldTypeCommandTest Renamed GeneratorPluginFieldTypeCommandTest.php located in Command and moved it to Generate as PluginFieldTypeCommandTest.php * Rename and move PluginFieldWidget Renamed GeneratorPluginFieldWidgetCommandTest.php located in Command and moved it to Generate as ControllerPluginFieldWidgetTest.php * Rename and move PluginImageEffectCommandTest Renamed GeneratorPluginImageEffectCommandTest.php located in Command and moved it to Generate as PluginImageEffectCommandTest.php * Rename and move PluginImageFormatter Renamed GeneratorPluginImageFormatterCommandTest.php located in Command and moved it to Generate as PluginImageFormatterCommandTest.php * Rename and move PluginRestResourceCommandTest Renamed GeneratorPluginRestResourceCommandTest.php located in Command and moved it to Generate as PluginRestResourceCommandTest.php * Rename and move PluginRulesActionCommandTest Renamed GeneratorPluginRulesActionCommandTest.php located in Command and moved it to Generate as PluginRulesActionCommandTest.php * Rename and move PluginTypeAnnotationCommandTest Renamed GeneratorPluginTypeAnnotationCommandTest.php located in Command and moved it to Generate as PluginTypeAnnotationCommandTest.php * Rename and move PluginTypeYamlCommandTest Renamed GeneratorPluginTypeYamlCommandTest.php located in Command and moved it to Generate as PluginTypeYamlCommandTest.php * Corrected the namespace of PluginConditionCommandTest * Rename and move ThemeCommandTest Renamed GeneratorThemeCommandTest.php located in Command and moved it to Generate as ThemeCommandTest.php * Rename and move PluginTypeYaml Renamed GeneratorPluginTypeYamlCommandTest.php located in Command and moved it to Generate as PluginTypeYamlCommandTest.php * Fix the class erasing Generator
* Fix GeneratorConfigFormBaseCommandTest * Sorting parameters according to dependency injection * Removing obsolete code * Rewriting test according to last code refactoring * Rewriting test according to last code refactoring * Fix bug from last refactoring code
* Add EntityConfigGenerator to the builder * Fix EntityConfigCommandTest
* Add PermissionGenerator to builder * Fix PermissionCommandTest * Corrected a misspelled
* Add EntityConfigGenerator to builder * Fix EntityCommandTest
* Add EntityContentGenerator to builder * Fix EntityContentCommandTest
* Create GenerateCommanTest in Generate folder * Add ModuleGenerator to the builder * Add the necessary mocks that ModuleCommand need
) * Rename test classes to match its subjects class' names. * Rename and move tests classes to match class and package names of its subjects under test. * Add keys to the arrays in the data providers methods. * Extract Questions object from AuthenticationProviderCommand. * Extract ConfirmGeneration object. * Do not modify the console input from the Questions object. * Add tests for interactive mode of AuthenticationProviderCommand. * Refactor AuthenticationProviderQuestions tests. * Refactor AuthenticationProviderCommand tests. * Remove unnecessary traits from command. * Refactor ConfirmGenerationTest. * Use the same convention for setup methods in tests.
* .gitignore * Add the missing lines
* .gitignore * Add the missing lines * Add the ControllerGenerator to a * Fix ControllerCommandTest
| @jasonahjie Not sure I understand your question. | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What does class a in L27 refers to?