Accept legacy const sampler type configuration (27.x) - #12368
Merged
tomas-langer merged 8 commits intoSep 2, 2026
Merged
Conversation
tomas-langer
added
tracing
backport
oracle-contributor-agreement
Bot
added
the
OCA Verified
tvallin
previously approved these changes
Aug 28, 2026
danielkec
previously approved these changes
Aug 28, 2026
danielkec
reviewed
Aug 28, 2026
danielkec
reviewed
Aug 28, 2026
danielkec
reviewed
Aug 31, 2026
danielkec
left a comment
danielkec
left a comment
Contributor
There was a problem hiding this comment.
Two current-head review findings.
(cherry picked from commit 49edbfa)
tomas-langer
force-pushed
the
12367-accept-legacy-const-sampler-type
branch
from
September 1, 2026 07:19
0f30617 to
f1c8038
Compare
tvallin
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #12367
This is a source-faithful carry-forward of 4.x PR #11988 and commit
49edbfa0tomain.Adds a configuration factory so the legacy
constsampler type maps toSamplerType.CONSTANTwithout adding another public enum value. Covers lowercase and uppercaseconstandconstantconfigurations.This carry-forward intentionally preserves inherited source behavior, including existing invalid-value diagnostics and generated config-metadata representation; it is not an attempt to resolve those findings.