Skip to content

Conversation

@poliorcetics
Copy link
Contributor

Completes a TODO that was in the code and prepare for #9643 (which I'll need to rebase on this before merging)

@poliorcetics
Copy link
Contributor Author

I kept the git feature but since this PR makes it fully configurable and helix moved to gitoxide since the feature addition, maybe we could remove it and let people define editor.vcs.providers = [] if they don't want any ?

@pascalkuthe
Copy link
Member

pascalkuthe commented Mar 15, 2024

helix moved to gitoxide since the feature addition

helix has only ever used gitoxide. Gitocide doesn't work with wasm so that's why that feature is there

In general the current approach is not what I want to go with here (I don't want the whole cascading fallback approach that wasn't a good design and now that we have workspace local config you can simply configure your vcs per workspace or globally). There is actually a finished/reviewed PR #8056 that just needs to be rebased

@poliorcetics
Copy link
Contributor Author

helix has only ever used gitoxide. Gitocide doesn't work with wasm so that's why that feature is there

Ah my bad I'm confusing it with others that migrated to gitoxide later then

Regarding the rest I commented on the other PR, I think the cascading fallback behavior is very useful and I think removing would be a big mistake

@pascalkuthe
Copy link
Member

if we are going to have autodetection I would just always autodetect by default without the option to configure and allow the config option from that pr to overwrite autodection.

@poliorcetics poliorcetics deleted the ab/push-xslzwluwxxqq branch March 19, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants