on iPad, on the spec review page, highlighting text with ...#1742
Merged
lukemarsden merged 1 commit intomainfrom Mar 2, 2026
Merged
on iPad, on the spec review page, highlighting text with ...#1742lukemarsden merged 1 commit intomainfrom
lukemarsden merged 1 commit intomainfrom
Conversation
Collaborator
lukemarsden
commented
Feb 24, 2026
lukemarsden
commented
Issue 1: Touch selection not opening comment panel - Added onTouchEnd handler alongside onMouseUp in DesignReviewContent - Added 50ms delay for iOS to finalize text selection before processing Issue 2: Comment panel obscures text on narrow viewports - Added useMediaQuery to detect viewports < 1000px - InlineCommentForm: renders as fixed bottom sheet on narrow viewports - InlineCommentBubble: renders inline below document on narrow viewports - Added auto-scroll to ensure comment form is visible after appearing Spec-Ref: helix-specs@3b3c71604:001375_on-ipad-on-the-spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.