implement window pinning #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitty-panics
added a commit
to kitty-panics/virgo
that referenced
this pull request
Apr 7, 2023
Title: implement window pinning Links: henkman#21 ```Describe-Text this is useful when you're running a multi-monitor setup and want some windows to persist on all desktops (such as having a performance monitor on your 2nd monitor) the hotkey for pinning is CTRL + SHIFT + ALT + P I opted for a small fixed size array to save memory since you're not gonna pin many windows anyway it's kind of a big patch (40+ lines) so I understand if you don't want to merge it to keep the lines of code count low tecnically using 0 as the empty hwnd value is wrong, but it's highly unlikely that a window that isn't a system window is gonna have HWND = 0, so it should be fine and it saves having to initialize the array to INVALID_WINDOW_HANDLE in virgo_init ```
wwxiaoqi
added a commit
to wwxiaoqi/virgo
that referenced
this pull request
Aug 18, 2023
Title: implement window pinning Links: henkman#21 ```Describe-Text this is useful when you're running a multi-monitor setup and want some windows to persist on all desktops (such as having a performance monitor on your 2nd monitor) the hotkey for pinning is CTRL + SHIFT + ALT + P I opted for a small fixed size array to save memory since you're not gonna pin many windows anyway it's kind of a big patch (40+ lines) so I understand if you don't want to merge it to keep the lines of code count low tecnically using 0 as the empty hwnd value is wrong, but it's highly unlikely that a window that isn't a system window is gonna have HWND = 0, so it should be fine and it saves having to initialize the array to INVALID_WINDOW_HANDLE in virgo_init ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is useful when you're running a multi-monitor setup and want some windows to persist on all desktops (such as having a performance monitor on your 2nd monitor)
the hotkey for pinning is CTRL + SHIFT + ALT + P
I opted for a small fixed size array to save memory since you're not gonna pin many windows anyway
it's kind of a big patch (40+ lines) so I understand if you don't want to merge it to keep the lines of code count low
tecnically using 0 as the empty hwnd value is wrong, but it's highly unlikely that a window that isn't a system window is gonna have HWND = 0, so it should be fine and it saves having to initialize the array to INVALID_WINDOW_HANDLE in virgo_init