[herd,test] Include x86_64 catalogue tests in default testing - #1806
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
maranget
force-pushed
the
more-x86_64-tests
branch
from
April 23, 2026 12:01
fc28692 to
18cbb80
Compare
maranget
changed the title
HadrienRenaud
approved these changes
Apr 23, 2026
Member
Author
Member
|
I agree, please go ahead. It will be easier to add X86_64 to the template test target in #1805. |
Contributor
|
Looks good to me! |
maranget
force-pushed
the
more-x86_64-tests
branch
from
April 23, 2026 16:14
18cbb80 to
a195ce3
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic X86_64 testing was not performed, as pointed out by several comments in PR #1804. Fix this problem by including catalogue X86_64 tests in the default testing
make test.